[SPARK-14752][SQL] LazilyGenerateOrdering throws NullPointerException #12661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with TakeOrderedAndProject
|
Test build #56897 has finished for PR 12661 at commit
|
Contributor
|
Could you add an regression test? |
| private[this] var generatedOrdering = GenerateOrdering.generate(ordering) | ||
|
|
||
| def compare(a: InternalRow, b: InternalRow): Int = { | ||
| if (generatedOrdering == null) { |
Contributor
There was a problem hiding this comment.
Should making the generatedOrdering as lazy val be enough?
see http://fdahms.com/2015/10/14/scala-and-the-transient-lazy-val-pattern/
Contributor
|
Since this one has been here for more than 10 days, I've provided another approach with new test case. Please take a look. Thanks. |
Contributor
|
@rajeshbalamohan, it appears that this issue has been fixed by #13466, so do you mind closing your pull request? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LazilyGenerateOrdering throws NullPointerException when clubbed with TakeOrderedAndProjectExec. This causes simple queries like "select i_item_id from item order by i_item_id limit 10;" would fail in spark-sql. Detailed explain plan and stack traces are available in SPARK-14752. When deserializing in DirectTaskResult, it goes through nested structure in Kryo causing NPE for generatedOrdering.
How was this patch tested?
Manual testing by running multiple SQL queries in multi node cluster.