Skip to content

[SPARK-14752][SQL] LazilyGenerateOrdering throws NullPointerException #12661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajeshbalamohan wants to merge 1 commit into from
Closed

[SPARK-14752][SQL] LazilyGenerateOrdering throws NullPointerException #12661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...t/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,14 @@ class LazilyGeneratedOrdering(val ordering: Seq[SortOrder]) extends Ordering[Int
private[this] var generatedOrdering = GenerateOrdering.generate(ordering)

def compare(a: InternalRow, b: InternalRow): Int = {
if (generatedOrdering == null) {
Copy link
Contributor

@davies davies May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should making the generatedOrdering as lazy val be enough?

see http://fdahms.com/2015/10/14/scala-and-the-transient-lazy-val-pattern/

generatedOrdering = GenerateOrdering.generate(ordering)
}
generatedOrdering.compare(a, b)
}

private def readObject(in: ObjectInputStream): Unit = Utils.tryOrIOException {
in.defaultReadObject()
generatedOrdering = GenerateOrdering.generate(ordering)
}
}

Expand Down