Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR removes sqlContext in examples. Actual usage was all replaced in #12809 but there are some in comments.

How was this patch tested?

Manual style checking.

@HyukjinKwon HyukjinKwon changed the title [MINOR][DOCS] Remove reamining sqlContext in documentation at examples [MINOR][DOCS] Remove remaining sqlContext in documentation at examples May 9, 2016
peopleFromJsonFile.registerTempTable("people");

// SQL statements can be run by using the sql methods provided by sqlContext.
// SQL statements can be run by using the sql methods provided by spark (SparkSession object).
Copy link
Member Author

@HyukjinKwon HyukjinKwon May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am less sure if spark (SparkSession object) is correct.
(It was a variable name (sqlContext) but for now I add (SparkSession object) with the variable name because it seems the name spark is confusing.)

Copy link
Contributor

@andrewor14 andrewor14 May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just say provided by spark

@SparkQA
Copy link

SparkQA commented May 9, 2016

Test build #58142 has finished for PR 13006 at commit 3c530ad.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented May 9, 2016

Merging into master 2.0 after making the changes I suggested.

By the way @HyukjinKwon in the future it's better to include more changes in a patch instead of submitting a trivial one like this one.

asfgit pushed a commit that referenced this pull request May 9, 2016
This PR removes `sqlContext` in examples. Actual usage was all replaced in #12809 but there are some in comments.

Manual style checking.

Author: hyukjinkwon <gurwls223@gmail.com>

Closes #13006 from HyukjinKwon/minor-docs.

(cherry picked from commit 2992a21)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in 2992a21 May 9, 2016
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented May 9, 2016

@andrewor14 Ah, sorry I will keep in mind.

@HyukjinKwon HyukjinKwon deleted the minor-docs branch January 2, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants