Skip to content

[MINOR][DOCS] Remove remaining sqlContext in documentation at examples #13006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 2 commits into from
Closed

[MINOR][DOCS] Remove remaining sqlContext in documentation at examples #13006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbfa98d
Typo in examples (sqlContext should be SparkSession)
HyukjinKwon May 9, 2016
3c530ad
Same ending dot at Java and Python examples
HyukjinKwon May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/src/main/java/org/apache/spark/examples/sql/JavaSparkSQL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public String call(Row row) {
// Register this DataFrame as a table.
peopleFromJsonFile.registerTempTable("people");

// SQL statements can be run by using the sql methods provided by sqlContext.
// SQL statements can be run by using the sql methods provided by spark (SparkSession object).
Copy link
Member Author

@HyukjinKwon HyukjinKwon May 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am less sure if spark (SparkSession object) is correct.
(It was a variable name (sqlContext) but for now I add (SparkSession object) with the variable name because it seems the name spark is confusing.)

Copy link
Contributor

@andrewor14 andrewor14 May 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just say provided by spark

Dataset<Row> teenagers3 = spark.sql("SELECT name FROM people WHERE age >= 13 AND age <= 19");

// The results of SQL queries are DataFrame and support all the normal RDD operations.
Expand Down
2 changes: 1 addition & 1 deletion examples/src/main/python/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
# Register this DataFrame as a temporary table.
people.registerTempTable("people")

# SQL statements can be run by using the sql methods provided by sqlContext
# SQL statements can be run by using the sql methods provided by spark (SparkSession object).
teenagers = spark.sql("SELECT name FROM people WHERE age >= 13 AND age <= 19")

for each in teenagers.collect():
Expand Down