[SPARK-15979][SQL] Rename various Parquet support classes. #13696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
JIRA is down - I will create a ticket when it comes back up. cc @liancheng |
| options: Map[String, String], | ||
| files: Seq[FileStatus]): Map[String, String] = { | ||
| def computeNumFeatures(): Int = { | ||
| val numFeatures = options.get("numFeatures").filter(_.toInt > 0).getOrElse { |
Contributor
Author
There was a problem hiding this comment.
cc @cloud-fan / @liancheng
I got rid of the nested function.
rxin
changed the title
Contributor
|
LGTM |
Contributor
|
LGTM pending Jenkins. |
|
Test build #60615 has finished for PR 13696 at commit
|
rxin
changed the title
Contributor
Author
|
Merging in master/2.0. |
Contributor
Author
|
I merged this into master but there is a conflict in 2.0. Going to submit a separate pr. |
Contributor
Author
|
See #13700 for branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 6, 2016
## What changes were proposed in this pull request? PR #13696 renamed various Parquet support classes but left `CatalystWriteSupport` behind. This PR is renames it as a follow-up. ## How was this patch tested? N/A. Author: Cheng Lian <lian@databricks.com> Closes #14070 from liancheng/spark-15979-follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch renames various Parquet support classes from CatalystAbc to ParquetAbc. This new naming makes more sense for two reasons:
How was this patch tested?
Renamed test cases as well.