Skip to content

Conversation

@sameeragarwal
Copy link
Member

What changes were proposed in this pull request?

This is a trivial patch that catches all OutOfMemoryError while building the broadcast hash relation and rethrows it by wrapping it in a nice error message.

How was this patch tested?

Existing Tests

@sameeragarwal
Copy link
Member Author

Here is the list of changes with whitespaces ignored: https://github.com/apache/spark/pull/14979/files?w=1

@sameeragarwal sameeragarwal changed the title Better error message for driver-side broadcast join OOMs [SPARK-17415][SQL] Better error message for driver-side broadcast join OOMs Sep 6, 2016
@sameeragarwal
Copy link
Member Author

cc @davies

@SparkQA
Copy link

SparkQA commented Sep 6, 2016

Test build #65005 has finished for PR 14979 at commit b3c5cfe.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 6, 2016

Test build #3250 has finished for PR 14979 at commit b3c5cfe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

LGTM - pending Jenkins.

@SparkQA
Copy link

SparkQA commented Sep 7, 2016

Test build #65054 has finished for PR 14979 at commit 3888632.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 7, 2016

Test build #3253 has finished for PR 14979 at commit 3888632.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

Merging to master. Thanks!

@asfgit asfgit closed this in 767d480 Sep 11, 2016
wgtmac pushed a commit to wgtmac/spark that referenced this pull request Sep 19, 2016
…n OOMs

## What changes were proposed in this pull request?

This is a trivial patch that catches all `OutOfMemoryError` while building the broadcast hash relation and rethrows it by wrapping it in a nice error message.

## How was this patch tested?

Existing Tests

Author: Sameer Agarwal <sameerag@cs.berkeley.edu>

Closes apache#14979 from sameeragarwal/broadcast-join-error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants