[SPARK-14634][ML][FOLLOWUP] Delete superfluous line in BisectingKMeans #15619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Oct 25, 2016
| val model = copyValues(new BisectingKMeansModel(uid, parentModel).setParent(this)) | ||
| val summary = new BisectingKMeansSummary( | ||
| model.transform(dataset), $(predictionCol), $(featuresCol), $(k)) | ||
| model.setSummary(summary) |
Member
There was a problem hiding this comment.
While we're here, isn't the rest of this method simpler as
model.setSummary(summary)
instr.logSuccess(model)
model
Contributor
Author
There was a problem hiding this comment.
@srowen Using another val m is to keep in line with KMeans.
But after refering to more algos (GMM/LoR/LiR), I think both KMeans and BisectingKMeans can be changed according to your comments. Thanks.
|
Test build #67502 has finished for PR 15619 at commit
|
srowen
approved these changes
Oct 25, 2016
|
Test build #67503 has finished for PR 15619 at commit
|
Contributor
|
LGTM, merged into master. Thanks! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? As commented by jkbradley in apache#12394, `model.setSummary(summary)` is superfluous ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes apache#15619 from zhengruifeng/del_superfluous.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? As commented by jkbradley in apache#12394, `model.setSummary(summary)` is superfluous ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes apache#15619 from zhengruifeng/del_superfluous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As commented by @jkbradley in #12394,
model.setSummary(summary)is superfluousHow was this patch tested?
existing tests