Skip to content

[SPARK-14634][ML][FOLLOWUP] Delete superfluous line in BisectingKMeans #15619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 2 commits into from
Closed

[SPARK-14634][ML][FOLLOWUP] Delete superfluous line in BisectingKMeans #15619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81460d4
create pr
zhengruifeng Oct 25, 2016
03f6a47
del_val_m
zhengruifeng Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,8 @@ class BisectingKMeans @Since("2.0.0") (
val summary = new BisectingKMeansSummary(
model.transform(dataset), $(predictionCol), $(featuresCol), $(k))
model.setSummary(summary)
Copy link
Member

@srowen srowen Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, isn't the rest of this method simpler as

model.setSummary(summary)
instr.logSuccess(model)
model

Copy link
Contributor Author

@zhengruifeng zhengruifeng Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen Using another val m is to keep in line with KMeans.
But after refering to more algos (GMM/LoR/LiR), I think both KMeans and BisectingKMeans can be changed according to your comments. Thanks.

val m = model.setSummary(summary)
instr.logSuccess(m)
m
instr.logSuccess(model)
model
}

@Since("2.0.0")
Expand Down
6 changes: 3 additions & 3 deletions mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,9 @@ class KMeans @Since("1.5.0") (
val model = copyValues(new KMeansModel(uid, parentModel).setParent(this))
val summary = new KMeansSummary(
model.transform(dataset), $(predictionCol), $(featuresCol), $(k))
val m = model.setSummary(summary)
instr.logSuccess(m)
m
model.setSummary(summary)
instr.logSuccess(model)
model
}

@Since("1.5.0")
Expand Down