Skip to content

[SPARK-21297] [WEB-UI]Add count in 'JDBC/ODBC Server' page. #18525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guoxiaolongzte wants to merge 2 commits into from
Closed

[SPARK-21297] [WEB-UI]Add count in 'JDBC/ODBC Server' page. #18525

guoxiaolongzte wants to merge 2 commits into from

Conversation

@guoxiaolongzte
Copy link

@guoxiaolongzte guoxiaolongzte commented Jul 4, 2017 •
edited
Loading

What changes were proposed in this pull request?

1.add count about 'Session Statistics' and 'SQL Statistics' in 'JDBC/ODBC Server' page.The purpose is to know the statistics clearly.

fix before:
1

fix after:
1

How was this patch tested?

manual tests

Please review http://spark.apache.org/contributing.html before opening a pull request.

ajbozarth
ajbozarth reviewed Jul 5, 2017
View reviewed changes
...thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala Outdated
<td> {session.userName} </td>
<td> {session.ip} </td>
<td> <a href={sessionLink}> {session.sessionId} </a> </td>
<td> {if (session.finishTimestamp > 0) "offline" else "online"} </td>
Copy link
Member

@ajbozarth ajbozarth Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is necessary? This same logic is applied to the "Finish Time" below. I don't think adding a column here is worthwhile.

Copy link
Author

@guoxiaolongzte guoxiaolongzte Jul 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but add this column, it is easy to observe and view. If you still do not recognize it, I will delete this column.Thanks.

Copy link
Member

@ajbozarth ajbozarth Jul 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be easier but it's still duplicate info, I don't think the extra column is needed

Copy link
Author

@guoxiaolongzte guoxiaolongzte Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted extra columns.

@ajbozarth
Copy link
Member

ajbozarth commented Jul 12, 2017

This LGTM, but could you update the title, description, and screenshots to match the current code changes?

@guoxiaolongzte guoxiaolongzte changed the title [SPARK-21297] [WEB-UI]Add State in 'Session Statistics' table and add count in 'JDBC/ODBC Server' page. [SPARK-21297] [WEB-UI]Add count in 'JDBC/ODBC Server' page. Jul 13, 2017
@guoxiaolongzte
Copy link
Author

guoxiaolongzte commented Jul 13, 2017

I have updated the title, description, and screenshots to match the current code changes.@ajbozarth

@ajbozarth
Copy link
Member

ajbozarth commented Jul 13, 2017

Thanks, but double check it, theres a few typos and the screenshots are still old

@guoxiaolongzte
Copy link
Author

guoxiaolongzte commented Jul 28, 2017

@ajbozarth Okay.Thanks.
@srowen Help review the code.Thanks.

@SparkQA
Copy link

SparkQA commented Jul 28, 2017

Test build #3855 has finished for PR 18525 at commit 4001028.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 30, 2017

Merged to master

@asfgit asfgit closed this in d79816d Jul 30, 2017
@guoxiaolongzte guoxiaolongzte mentioned this pull request Oct 16, 2017
Closed
ghost pushed a commit to dbtsai/spark that referenced this pull request Oct 30, 2017
@srowen
[WEB-UI] Add count in fair scheduler pool page
3663764 
## What changes were proposed in this pull request?

Add count in fair scheduler pool page. The purpose is to know the statistics clearly.
For specific reasons, please refer to PR of apache#18525

fix before:
![1](https://user-images.githubusercontent.com/26266482/31641589-4b17b970-b318-11e7-97eb-f5a36db428f6.png)

![2](https://user-images.githubusercontent.com/26266482/31641643-97b6345a-b318-11e7-8c20-4b164ade228d.png)

fix after:
![3](https://user-images.githubusercontent.com/26266482/31641688-e6ceacb6-b318-11e7-8204-6a816c581a29.png)

![4](https://user-images.githubusercontent.com/26266482/31641766-7310b0c0-b319-11e7-871d-a57f874f1e8b.png)

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: guoxiaolong <guo.xiaolong1@zte.com.cn>

Closes apache#19507 from guoxiaolongzte/add_count_in_fair_scheduler_pool_page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ajbozarth ajbozarth ajbozarth left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guoxiaolongzte @ajbozarth @SparkQA @srowen