Skip to content

Conversation

@guoxiaolongzte
Copy link

@guoxiaolongzte guoxiaolongzte commented Oct 16, 2017

What changes were proposed in this pull request?

Add count in fair scheduler pool page. The purpose is to know the statistics clearly.
For specific reasons, please refer to PR of #18525

fix before:
1

2

fix after:
3

4

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

@guoxiaolongzte guoxiaolongzte changed the title add count in fair scheduler pool page [WEB-UI] Add count in fair scheduler pool page Oct 17, 2017
@ajbozarth
Copy link
Member

This change for UI consistency is fine by me, but looking at the actually code I'm not sure where the parenthesis in the screen shots come from given all you did was move the number from the front to the end of each header.

@guoxiaolongzte
Copy link
Author

@ajbozarth
Sorry, upload the code before I accidentally withdrew the parenthesis. I rejoined the parenthesis. I have fixed it.

@guoxiaolongzte
Copy link
Author

Please refer to #19346

@guoxiaolongzte
Copy link
Author

@srowen
Help review the code.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fine for consistency.

@SparkQA
Copy link

SparkQA commented Oct 30, 2017

Test build #3964 has finished for PR 19507 at commit 4b6bf18.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 30, 2017

Merged to master

@asfgit asfgit closed this in 3663764 Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants