[SPARK-10063] Follow-up: remove dead code related to an old output committer #18689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #79796 has finished for PR 18689 at commit
|
|
Test build #79797 has finished for PR 18689 at commit
|
Member
|
Thanks! Merging to master. |
gatorsmile
reviewed
Jul 20, 2017
| * Instantiates a FileCommitProtocol using the given className. | ||
| */ | ||
| def instantiate(className: String, jobId: String, outputPath: String, isAppend: Boolean) | ||
| def instantiate(className: String, jobId: String, outputPath: String) |
Member
There was a problem hiding this comment.
If anybody in open source community needs it, please let us know.
|
Shouldn't https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala#L786 also be removed? As I understand it it checks whether the code removed here exists. |
Contributor
Author
|
interesting, that test should be removed, or the test should fail, let me take a closer look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DirectParquetOutputCommitter was removed from Spark as it was deemed unsafe to use. We however still have some code to generate warning. This patch removes those code as well.
This is kind of a follow-up of #16796
How was this patch tested?
existing tests