[SPARK-10063] Follow-up: remove a useless test related to an old output committer #18716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cloud-fan
commented
Jul 23, 2017
| // Because there data already exists, | ||
| // this append should succeed because we will use the output committer associated | ||
| // with file format and AlwaysFailOutputCommitter will not be used. | ||
| df.write.mode("append").format(dataSourceName).save(dir.getCanonicalPath) |
Contributor
Author
There was a problem hiding this comment.
this test is wrong because it didn't call .options(extraOptions), that's why I missed it in my previous PR...
|
Test build #79874 has finished for PR 18716 at commit
|
|
LGTM, Thanks for looking into this. |
Contributor
Author
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's a follow-up of #18689 , which forgot to remove a useless test.
How was this patch tested?
N/A