[MINOR][R][BUILD] More reliable detection of R version for Windows in AppVeyor #18859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @felixcheung, trivial but I believe this should be more correct. |
HyukjinKwon
changed the title
viirya
reviewed
Aug 6, 2017
|
|
||
| $urlPath = "" | ||
| $latestVer = $(ConvertFrom-JSON $(Invoke-WebRequest http://rversions.r-pkg.org/r-release).Content).version | ||
| $latestVer = $(ConvertFrom-JSON $(Invoke-WebRequest http://rversions.r-pkg.org/r-release-win).Content).version |
Member
There was a problem hiding this comment.
I saw from http://rversions.r-pkg.org/r-release-win, it has a URL field:
"URL": "https://cran.r-project.org/bin/windows/base/R-3.4.1-win.exe"
If we go to use this URL, maybe we don't need to combine rurl below?
Member
There was a problem hiding this comment.
Oh, I saw there is old/ path. Then we still need to manually combine rurl.
Member
Author
There was a problem hiding this comment.
Yes, but I think it'd be a good idea if we introduce something like latest as discussed in #15709 later.
|
Test build #80301 has finished for PR 18859 at commit
|
felixcheung
approved these changes
Aug 6, 2017
Member
Author
|
Merged this to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to use https://rversions.r-pkg.org/r-release-win instead of https://rversions.r-pkg.org/r-release to check R's version for Windows correctly.
We met a syncing problem with Windows release (see #15709) before. To cut this short, it was ...
https://rversions.r-pkg.org/r-releasereturns the latest as 3.3.2 and the download link for 3.3.1 becomeswindows/base/oldby our scriptwindows/base/oldbutwindows/baseas the latestwindows/base/oldlink and builds were brokenI believe this problem is not only what we met. Please see krlmlr/r-appveyor@01ce943 and also this
r-release-winAPI came out between 3.3.1 and 3.3.2 (assuming to deal with this issue), please seehttps://github.com/metacran/rversions.app/issues/2.Using this API will prevent the problem although it looks quite rare assuming from the commit logs in https://github.com/metacran/rversions.app/commits/master. After 3.3.2, both
r-release-winandr-releaseare being updated together.How was this patch tested?
AppVeyor tests.