Skip to content

[MINOR][R][BUILD] More reliable detection of R version for Windows in AppVeyor #18859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[MINOR][R][BUILD] More reliable detection of R version for Windows in AppVeyor #18859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/appveyor-install-dependencies.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Function InstallR {
}

$urlPath = ""
$latestVer = $(ConvertFrom-JSON $(Invoke-WebRequest http://rversions.r-pkg.org/r-release).Content).version
$latestVer = $(ConvertFrom-JSON $(Invoke-WebRequest http://rversions.r-pkg.org/r-release-win).Content).version
Copy link
Member

@viirya viirya Aug 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw from http://rversions.r-pkg.org/r-release-win, it has a URL field:

"URL": "https://cran.r-project.org/bin/windows/base/R-3.4.1-win.exe"

If we go to use this URL, maybe we don't need to combine rurl below?

Copy link
Member

@viirya viirya Aug 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I saw there is old/ path. Then we still need to manually combine rurl.

Copy link
Member Author

@HyukjinKwon HyukjinKwon Aug 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think it'd be a good idea if we introduce something like latest as discussed in #15709 later.

If ($rVer -ne $latestVer) {
$urlPath = ("old/" + $rVer + "/")
}
Expand Down