Skip to content

SPARK-3009: Reverted readObject method in ApplicationInfo so that Applic... #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jacek-lewandowski wants to merge 1 commit into from
Closed

SPARK-3009: Reverted readObject method in ApplicationInfo so that Applic... #1922

jacek-lewandowski wants to merge 1 commit into from

Conversation

@jacek-lewandowski
Copy link
Contributor

@jacek-lewandowski jacek-lewandowski commented Aug 13, 2014

...ationInfo is initialized properly after deserialization

@jacek-lewandowski
SPARK-3009: Reverted readObject method in ApplicationInfo so that App…
13c1fb3 
…licationInfo is initialized properly after deserialization
@AmplabJenkins
Copy link

AmplabJenkins commented Aug 13, 2014

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

andrewor14 commented Aug 13, 2014

test this please

andrewor14
andrewor14 reviewed Aug 13, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala
Copy link
Contributor

@andrewor14 andrewor14 Aug 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: no space before colon

@andrewor14
Copy link
Contributor

andrewor14 commented Aug 13, 2014

LGTM. I verified that this is the same as before I removed it.

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1922. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18450/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1922:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18450/consoleFull

@jacek-lewandowski
Copy link
Contributor Author

jacek-lewandowski commented Aug 14, 2014

So what is the next step? Is it going to be included in 1.0.x?

asfgit pushed a commit that referenced this pull request Aug 14, 2014
@jacek-lewandowski @andrewor14
SPARK-3009: Reverted readObject method in ApplicationInfo so that App…
6c6409e 
…lic...

...ationInfo is initialized properly after deserialization

Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>

Closes #1922 from jacek-lewandowski/branch-1.0 and squashes the following commits:

13c1fb3 [Jacek Lewandowski] SPARK-3009: Reverted readObject method in ApplicationInfo so that ApplicationInfo is initialized properly after deserialization
@andrewor14
Copy link
Contributor

andrewor14 commented Aug 14, 2014

Thanks I've merged this.

@andrewor14
Copy link
Contributor

andrewor14 commented Aug 14, 2014

@jacek-lewandowski I realize this is only for branch-1.0. Could you also make the same PR for master?

@jacek-lewandowski
Copy link
Contributor Author

jacek-lewandowski commented Aug 14, 2014

@andrewor14 - created #1947

@JoshRosen
Copy link
Contributor

JoshRosen commented Aug 24, 2014

@jacek-lewandowski do you mind closing this PR, since GitHub won't do it automatically? Thanks!

@asfgit asfgit closed this in 9b8c228 Aug 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jacek-lewandowski @AmplabJenkins @andrewor14 @SparkQA @JoshRosen