[SPARK-22309][ML] Remove unused param in LDAModel.getTopicDistributionMethod
#19530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #82898 has finished for PR 19530 at commit
|
Member
|
This is probably OK but let's focus away from making many tiny unrelated changes |
zhengruifeng
changed the title
LDAModel.getTopicDistributionMethod & destory nodeToFeaturesBc in RandomForestLDAModel.getTopicDistributionMethod
|
Test build #82907 has finished for PR 19530 at commit
|
Member
|
LGTM |
Member
|
fyi it looks like this is cleanup from removing a broadcast in #18152 |
Member
|
Agree, I've merged the JIRA. Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unused param in
LDAModel.getTopicDistributionMethodHow was this patch tested?
existing tests