Skip to content

[SPARK-22309][ML] Remove unused param in LDAModel.getTopicDistributionMethod #19530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 3 commits into from
Closed

[SPARK-22309][ML] Remove unused param in LDAModel.getTopicDistributionMethod #19530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4d2cad
create pr
zhengruifeng Oct 19, 2017
5046240
update pr
zhengruifeng Oct 19, 2017
ccd4278
update pr
zhengruifeng Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ abstract class LDAModel private[ml] (
if ($(topicDistributionCol).nonEmpty) {

// TODO: Make the transformer natively in ml framework to avoid extra conversion.
val transformer = oldLocalModel.getTopicDistributionMethod(sparkSession.sparkContext)
val transformer = oldLocalModel.getTopicDistributionMethod

val t = udf { (v: Vector) => transformer(OldVectors.fromML(v)).asML }
dataset.withColumn($(topicDistributionCol), t(col($(featuresCol)))).toDF()
Expand Down
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ class LocalLDAModel private[spark] (
/**
* Get a method usable as a UDF for `topicDistributions()`
*/
private[spark] def getTopicDistributionMethod(sc: SparkContext): Vector => Vector = {
private[spark] def getTopicDistributionMethod: Vector => Vector = {
val expElogbeta = exp(LDAUtils.dirichletExpectation(topicsMatrix.asBreeze.toDenseMatrix.t).t)
val docConcentrationBrz = this.docConcentration.asBreeze
val gammaShape = this.gammaShape
Expand Down