-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3065][SQL] Add locale setting to fix results do not match for udf_unix_timestamp format "yyyy MMM dd h:mm:ss a" run with not "America/Los_Angeles" TimeZone in HiveCompatibilitySuite #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
test this please |
|
Jenkins, test this please. |
|
test this please |
|
QA tests have started for PR 1968 at commit
|
|
QA tests have finished for PR 1968 at commit
|
|
@marmbrus From the console log, unit tests failure is not because of my case, but hive thrift server. |
|
It's the Kerberos issue again. Thrift server test suites pass when executed separately, but fail non-deterministically when executed with other tests. I guess they're affected by side effects of some other tests that occasionally got executed before Thrift server ones. Trying to figure out suspicious test suites. This PR itself LGTM. |
|
@liancheng Now I need to do what? |
|
Jenkins, retest this please. |
|
Jenkins, test this please. |
|
QA tests have started for PR 1968 at commit
|
|
QA tests have finished for PR 1968 at commit
|
|
The build failure was caused by unrelated streaming test suites. |
|
Jenkins, retest this please. |
|
ok to test |
|
QA tests have started for PR 1968 at commit
|
|
QA tests have finished for PR 1968 at commit
|
|
Thanks! I've merged this into master and 1.1 |
…udf_unix_timestamp format "yyyy MMM dd h:mm:ss a" run with not "America/Los_Angeles" TimeZone in HiveCompatibilitySuite When run the udf_unix_timestamp of org.apache.spark.sql.hive.execution.HiveCompatibilitySuite testcase with not "America/Los_Angeles" TimeZone throws error. [https://issues.apache.org/jira/browse/SPARK-3065] add locale setting on beforeAll and afterAll method to fix the bug of HiveCompatibilitySuite testcase Author: luogankun <luogankun@gmail.com> Closes #1968 from luogankun/SPARK-3065 and squashes the following commits: c167832 [luogankun] [SPARK-3065][SQL] Add Locale setting to HiveCompatibilitySuite 0a25e3a [luogankun] [SPARK-3065][SQL] Add Locale setting to HiveCompatibilitySuite (cherry picked from commit 6525350) Signed-off-by: Michael Armbrust <michael@databricks.com>
…udf_unix_timestamp format "yyyy MMM dd h:mm:ss a" run with not "America/Los_Angeles" TimeZone in HiveCompatibilitySuite When run the udf_unix_timestamp of org.apache.spark.sql.hive.execution.HiveCompatibilitySuite testcase with not "America/Los_Angeles" TimeZone throws error. [https://issues.apache.org/jira/browse/SPARK-3065] add locale setting on beforeAll and afterAll method to fix the bug of HiveCompatibilitySuite testcase Author: luogankun <luogankun@gmail.com> Closes apache#1968 from luogankun/SPARK-3065 and squashes the following commits: c167832 [luogankun] [SPARK-3065][SQL] Add Locale setting to HiveCompatibilitySuite 0a25e3a [luogankun] [SPARK-3065][SQL] Add Locale setting to HiveCompatibilitySuite
When run the udf_unix_timestamp of org.apache.spark.sql.hive.execution.HiveCompatibilitySuite testcase
with not "America/Los_Angeles" TimeZone throws error. [https://issues.apache.org/jira/browse/SPARK-3065]
add locale setting on beforeAll and afterAll method to fix the bug of HiveCompatibilitySuite testcase