Skip to content

[SPARK-3065][SQL] Add locale setting to fix results do not match for udf_unix_timestamp format "yyyy MMM dd h:mm:ss a" run with not "America/Los_Angeles" TimeZone in HiveCompatibilitySuite #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luogankun wants to merge 2 commits into from
Closed

[SPARK-3065][SQL] Add locale setting to fix results do not match for udf_unix_timestamp format "yyyy MMM dd h:mm:ss a" run with not "America/Los_Angeles" TimeZone in HiveCompatibilitySuite #1968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a25e3a
[SPARK-3065][SQL] Add Locale setting to HiveCompatibilitySuite
luogankun Aug 15, 2014
c167832
[SPARK-3065][SQL] Add Locale setting to HiveCompatibilitySuite
luogankun Aug 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...atibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
package org.apache.spark.sql.hive.execution

import java.io.File
import java.util.TimeZone
import java.util.{Locale, TimeZone}

import org.scalatest.BeforeAndAfter

Expand All @@ -33,6 +33,7 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
File.separator + "test" + File.separator + "queries" + File.separator + "clientpositive")

var originalTimeZone: TimeZone = _
var originalLocale: Locale = _

def testCases = hiveQueryDir.listFiles.map(f => f.getName.stripSuffix(".q") -> f)

Expand All @@ -41,11 +42,16 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
// Timezone is fixed to America/Los_Angeles for those timezone sensitive tests (timestamp_*)
originalTimeZone = TimeZone.getDefault
TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"))

// Add Locale setting
originalLocale = Locale.getDefault
Locale.setDefault(Locale.US)
}

override def afterAll() {
TestHive.cacheTables = false
TimeZone.setDefault(originalTimeZone)
Locale.setDefault(originalLocale)
}

/** A list of tests deemed out of scope currently and thus completely disregarded. */
Expand Down