Skip to content

Conversation

@henryr
Copy link
Contributor

@henryr henryr commented Nov 9, 2017

What changes were proposed in this pull request?

The merge of SPARK-22211 to branch-2.2 dropped a couple of important lines that made sure the tests that compared plans did so with both plans having been analyzed. Fix by reintroducing the correct analysis statements.

How was this patch tested?

Re-ran LimitPushdownSuite. All tests passed.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.
Thank you, @henryr .

@SparkQA
Copy link

SparkQA commented Nov 9, 2017

Test build #83615 has finished for PR 19701 at commit 890f608.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

The failure is not related to this.

Traceback (most recent call last):
  File "/home/anaconda/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/home/anaconda/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/sql/tests.py", line 196, in <module>
    class SQLTests(ReusedPySparkTestCase):
  File "/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/sql/tests.py", line 2200, in SQLTests
    @unittest.skipIf(not _have_pandas, "Pandas not installed")
NameError: name '_have_pandas' is not defined

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Nov 9, 2017

Test build #83624 has finished for PR 19701 at commit 890f608.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Retest this please.

asfgit pushed a commit that referenced this pull request Nov 9, 2017
## What changes were proposed in this pull request?

The merge of SPARK-22211 to branch-2.2 dropped a couple of important lines that made sure the tests that compared plans did so with both plans having been analyzed. Fix by reintroducing the correct analysis statements.

## How was this patch tested?

Re-ran LimitPushdownSuite. All tests passed.

Author: Henry Robinson <henry@apache.org>

Closes #19701 from henryr/branch-2.2.
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

gatorsmile commented Nov 9, 2017

The test cases already passed.

Thanks! Merged to 2.2.

@dongjoon-hyun
Copy link
Member

Thank you, @gatorsmile and @henryr !

@dongjoon-hyun
Copy link
Member

Please close this PR, @henryr . branch-2.2 PR is not closed automatically.

@henryr henryr closed this Nov 9, 2017
@felixcheung
Copy link
Member

thanks!

MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
## What changes were proposed in this pull request?

The merge of SPARK-22211 to branch-2.2 dropped a couple of important lines that made sure the tests that compared plans did so with both plans having been analyzed. Fix by reintroducing the correct analysis statements.

## How was this patch tested?

Re-ran LimitPushdownSuite. All tests passed.

Author: Henry Robinson <henry@apache.org>

Closes apache#19701 from henryr/branch-2.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants