-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests #19701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Thank you, @henryr .
|
Test build #83615 has finished for PR 19701 at commit
|
|
The failure is not related to this. |
|
Retest this please. |
|
Test build #83624 has finished for PR 19701 at commit
|
|
Retest this please. |
## What changes were proposed in this pull request? The merge of SPARK-22211 to branch-2.2 dropped a couple of important lines that made sure the tests that compared plans did so with both plans having been analyzed. Fix by reintroducing the correct analysis statements. ## How was this patch tested? Re-ran LimitPushdownSuite. All tests passed. Author: Henry Robinson <henry@apache.org> Closes #19701 from henryr/branch-2.2.
gatorsmile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
The test cases already passed. Thanks! Merged to 2.2. |
|
Thank you, @gatorsmile and @henryr ! |
|
Please close this PR, @henryr . |
|
thanks! |
## What changes were proposed in this pull request? The merge of SPARK-22211 to branch-2.2 dropped a couple of important lines that made sure the tests that compared plans did so with both plans having been analyzed. Fix by reintroducing the correct analysis statements. ## How was this patch tested? Re-ran LimitPushdownSuite. All tests passed. Author: Henry Robinson <henry@apache.org> Closes apache#19701 from henryr/branch-2.2.
What changes were proposed in this pull request?
The merge of SPARK-22211 to branch-2.2 dropped a couple of important lines that made sure the tests that compared plans did so with both plans having been analyzed. Fix by reintroducing the correct analysis statements.
How was this patch tested?
Re-ran LimitPushdownSuite. All tests passed.