Skip to content

[SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests #19701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henryr wants to merge 1 commit into from
Closed

[SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests #19701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,26 +111,26 @@ class LimitPushdownSuite extends PlanTest {

test("full outer join where neither side is limited and both sides have same statistics") {
assert(x.stats(conf).sizeInBytes === y.stats(conf).sizeInBytes)
val originalQuery = x.join(y, FullOuter).limit(1)
val optimized = Optimize.execute(originalQuery.analyze)
val originalQuery = x.join(y, FullOuter).limit(1).analyze
val optimized = Optimize.execute(originalQuery)
// No pushdown for FULL OUTER JOINS.
comparePlans(optimized, originalQuery)
}

test("full outer join where neither side is limited and left side has larger statistics") {
val xBig = testRelation.copy(data = Seq.fill(2)(null)).subquery('x)
assert(xBig.stats(conf).sizeInBytes > y.stats(conf).sizeInBytes)
val originalQuery = xBig.join(y, FullOuter).limit(1)
val optimized = Optimize.execute(originalQuery.analyze)
val originalQuery = xBig.join(y, FullOuter).limit(1).analyze
val optimized = Optimize.execute(originalQuery)
// No pushdown for FULL OUTER JOINS.
comparePlans(optimized, originalQuery)
}

test("full outer join where neither side is limited and right side has larger statistics") {
val yBig = testRelation.copy(data = Seq.fill(2)(null)).subquery('y)
assert(x.stats(conf).sizeInBytes < yBig.stats(conf).sizeInBytes)
val originalQuery = x.join(yBig, FullOuter).limit(1)
val optimized = Optimize.execute(originalQuery.analyze)
val originalQuery = x.join(yBig, FullOuter).limit(1).analyze
val optimized = Optimize.execute(originalQuery)
// No pushdown for FULL OUTER JOINS.
comparePlans(optimized, originalQuery)
}
Expand Down