[SPARK-23024][WEB-UI]Spark ui about the contents of the form need to have hidden and show features, when the table records very much. #20216

guoxiaolongzte · 2018-01-10T08:19:35Z

What changes were proposed in this pull request?

Spark ui about the contents of the form need to have hidden and show features, when the table records very much. Because sometimes you do not care about the record of the table, you just want to see the contents of the next table, but you have to scroll the scroll bar for a long time to see the contents of the next table.

Currently we have about 500 workers, but I just wanted to see the logs for the running applications table. I had to scroll through the scroll bars for a long time to see the logs for the running applications table.

In order to ensure functional consistency, I modified the Master Page, Worker Page, Job Page, Stage Page, Task Page, Configuration Page, Storage Page, Pool Page.

fix before:

fix after:

How was this patch tested?

manual tests

Please review http://spark.apache.org/contributing.html before opening a pull request.

…have hidden and show features, when the table records very much.

ajbozarth · 2018-01-11T00:05:42Z

Since this is a UI change can you post screenshots, and I'm not 100% convinced on the necessity of this when we already have jump links at the top of most pages.

guoxiaolongzte · 2018-01-11T02:51:41Z

Dear Sir, However, the real spark big data environment, a very large number of workers, every day running a very large number of applications, has completed a very large number of applications, there are also some failed applications.
When so much data are loaded into the WEB UI, coupled with slow Internet access and other factors, if you have a hidden form of the function, not only for the overall look and feel of the WEB UI neat, more personal feel more convenient than jump access.
If you jump to a table and view the table's records, if you want to see the records in other tables, you have to flip it up and down because the jump's link is at the top of the page.
Attachment has been uploaded.

srowen · 2018-01-11T11:16:15Z

But @guoxiaolongzte your change doesn't cause it to load less data, right?

guoxiaolongzte · 2018-01-11T11:28:44Z

No, just hide the table, in fact, the data is already on the page, but we can not see.
When we refresh the page, it will re-show all the data.

ajbozarth · 2018-01-11T20:33:28Z

Hiding Tables like this has been done elsewhere in the UI (can't remember where right now though). In that case there's a triangle marker next to the Header that shows that it's collapsable and it also persists across page load. If we decided to do this I think we should emulate that previous example

guoxiaolongzte · 2018-01-12T01:54:16Z

I'm going to achieve it, this is a good idea.

…stency of the function.

guoxiaolongzte · 2018-01-12T05:41:06Z

@ajbozarth @srowen
Fix the code, increase the arrow of the form page, maintain the consistency of the function.

after fix:

ajbozarth

So this is growing on me, it's actually pretty useful after all.
Looking at the previous example of aggregated-metrics in StagePage.scala I have a couple of code suggestions though:

You should move the class and onClick from the h4 to a surrounding span
In order for collapsible tables to persist on reload each table much be added to the function at the bottom on web.js which I created with this possible future in mind. If you have a better suggestion for persistence though I'd love to hear it, mine is a bit brute force.

guoxiaolongzte · 2018-01-13T09:02:28Z

The first suggestion, I will fix it.
The second suggestion, I think it is not necessary. Because spark system is small, such as 3 workers, do not need to hide the table from the beginning.

guoxiaolongzte · 2018-01-15T07:34:00Z

@ajbozarth
The first suggestion, I have already fixed it.

ajbozarth · 2018-01-15T19:42:17Z

Thanks for updating the first one, but I stand by the second. The UI should be consistent and in the previous use of this feature it persisted so it should here, even if it's not necessary every time.

guoxiaolongzte · 2018-01-16T06:20:40Z

I agree with your second suggestion, before I did not understand what you mean, now I passed the test I understand what you mean.

1.In order for collapsible tables to persist on reload each table much be added to the function at the bottom on web.js. When I refresh the page, if it is hidden, will still be hidden; if it is displayed, will still be displayed.

2.to ensure user interface consistency.

@ajbozarth @srowen

ajbozarth · 2018-01-16T06:26:55Z

LGTM now

SparkQA · 2018-01-16T16:17:00Z

Test build #4055 has started for PR 20216 at commit 4b6cdbb.

srowen · 2018-01-16T16:17:10Z

This basically just makes the Workers / Apps lists collapsible in the same way as other blocks? that sounds fine.

guoxiaolongzte · 2018-01-17T01:16:08Z

Yes, it makes the Workers / Apps lists collapsible in the same way as other blocks.

guoxiaolongzte · 2018-01-17T05:42:51Z

test this please

SparkQA · 2018-01-17T18:38:15Z

Test build #4056 has finished for PR 20216 at commit 4b6cdbb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

guoxiaolongzte · 2018-01-18T02:14:38Z

Please help merge code, thank you. @srowen

AmplabJenkins · 2018-01-18T17:29:53Z

Can one of the admins verify this patch?

srowen · 2018-01-19T14:22:48Z

Merged to master

…r need to have hidden and show features, when the table records very much. ## What changes were proposed in this pull request? Spark Streaming ui about the contents of the for need to have hidden and show features, when the table records very much. please refer to #20216 fix after: ![1](https://user-images.githubusercontent.com/26266482/36068644-df029328-0f14-11e8-8350-cfdde9733ffc.png) ## How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. Author: guoxiaolong <guo.xiaolong1@zte.com.cn> Closes #20570 from guoxiaolongzte/SPARK-23382.

…, to make it consistent with other tabs. ## What changes were proposed in this pull request? Currently, SQL tab in the WEBUI doesn't support hiding table. Other tabs in the web ui like, Jobs, stages etc supports hiding table (refer SPARK-23024 apache#20216). In this PR, added the support for hide table in the sql tab also. ## How was this patch tested? bin/spark-shell ``` sql("create table a (id int)") for(i <- 1 to 100) sql(s"insert into a values ($i)") ``` Open SQL tab in the web UI **Before fix:** ![image](https://user-images.githubusercontent.com/23054875/46249137-f5c44880-c441-11e8-953a-a811e33ac24d.png) **After fix:** Consistent with the other tabs. ![screenshot from 2018-09-30 00-11-28](https://user-images.githubusercontent.com/23054875/46249354-75074b80-c445-11e8-9417-28751fd8628a.png) (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. Closes apache#22592 from shahidki31/SPARK-25575. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>

[SPARK-23024][WEB-UI]Spark ui about the contents of the form need to …

1e4a186

…have hidden and show features, when the table records very much.

Fix the code, increase the arrow of the form page, maintain the consi…

c5e71cc

…stency of the function.

ajbozarth suggested changes Jan 12, 2018

View reviewed changes

[SPARK-23024]fix the code to fix the style

1e3df81

[SPARK-23024] fix the code

4b6cdbb

asfgit closed this in e1c33b6 Jan 19, 2018

guoxiaolongzte mentioned this pull request Feb 11, 2018

[spark-23382][WEB-UI]Spark Streaming ui about the contents of the for need to have hidden and show features, when the table records very much. #20570

Closed

shahidki31 mentioned this pull request Sep 29, 2018

[SPARK-25575][WEBUI][SQL] SQL tab in the spark UI support hide tables, to make it consistent with other tabs. #22592

Closed

[SPARK-23024][WEB-UI]Spark ui about the contents of the form need to have hidden and show features, when the table records very much. #20216

[SPARK-23024][WEB-UI]Spark ui about the contents of the form need to have hidden and show features, when the table records very much. #20216

Uh oh!

Conversation

guoxiaolongzte commented Jan 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

ajbozarth commented Jan 11, 2018

Uh oh!

guoxiaolongzte commented Jan 11, 2018

Uh oh!

srowen commented Jan 11, 2018

Uh oh!

guoxiaolongzte commented Jan 11, 2018

Uh oh!

ajbozarth commented Jan 11, 2018

Uh oh!

guoxiaolongzte commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guoxiaolongzte commented Jan 12, 2018

Uh oh!

ajbozarth left a comment

Choose a reason for hiding this comment

Uh oh!

guoxiaolongzte commented Jan 13, 2018

Uh oh!

guoxiaolongzte commented Jan 15, 2018

Uh oh!

ajbozarth commented Jan 15, 2018

Uh oh!

guoxiaolongzte commented Jan 16, 2018

Uh oh!

ajbozarth commented Jan 16, 2018

Uh oh!

SparkQA commented Jan 16, 2018

Uh oh!

srowen commented Jan 16, 2018

Uh oh!

guoxiaolongzte commented Jan 17, 2018

Uh oh!

guoxiaolongzte commented Jan 17, 2018

Uh oh!

SparkQA commented Jan 17, 2018

Uh oh!

guoxiaolongzte commented Jan 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmplabJenkins commented Jan 18, 2018

Uh oh!

srowen commented Jan 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guoxiaolongzte commented Jan 10, 2018 •

edited

Loading

guoxiaolongzte commented Jan 12, 2018 •

edited

Loading

guoxiaolongzte commented Jan 18, 2018 •

edited

Loading