[spark-23382][WEB-UI]Spark Streaming ui about the contents of the for need to have hidden and show features, when the table records very much. #20570
Conversation
…m need to have hidden and show features, when the table records very much.
| collapseTablePageLoad('collapse-aggregated-poolActiveStages','aggregated-poolActiveStages'); | ||
| collapseTablePageLoad('collapse-aggregated-tasks','aggregated-tasks'); | ||
| collapseTablePageLoad('collapse-aggregated-rdds','aggregated-rdds'); | ||
| collapseTablePageLoad('collapse-aggregated-activeBatches','aggregated-activeBatches'); |
There was a problem hiding this comment.
Probably should not collapse the active batches; they are important and won't be numerous.
CC @ajbozarth
There was a problem hiding this comment.
I would agree there's no reason to, but this simply enables user to if they want. And I would prefer the uniform look and feel of have all tables collapsible like the other pages.
There was a problem hiding this comment.
Oh I see. This doesn't also collapse by default? I wondered because of what the name "collapseTablePageLoad" seemed to suggest. Sure, the capability is fine.
There was a problem hiding this comment.
This function just makes sure to persist collapsed tables on page reload
ajbozarth
left a comment
ajbozarth
left a comment
There was a problem hiding this comment.
LGTM, does this update make all tables in the UI collapsible now or are there still pages with non-collapsible tables?
|
Okay, I check the other pages again today. |
|
Test build #4095 has finished for PR 20570 at commit
|
|
Merged to master |
4 participants
What changes were proposed in this pull request?
Spark Streaming ui about the contents of the for need to have hidden and show features, when the table records very much.
please refer to #20216
fix after:
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.