[SPARK-24768][FollowUp][SQL]Avro migration followup: change artifactId to spark-avro #21866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
reviewed
Jul 24, 2018
| options: Map[String, String], | ||
| files: Seq[FileStatus]): Option[StructType] = { | ||
| val conf = spark.sparkContext.hadoopConfiguration | ||
| val conf = spark.sessionState.newHadoopConf() |
Contributor
There was a problem hiding this comment.
can we add a linter rule for this?
Member
Author
There was a problem hiding this comment.
Sure, will do it.
Can I make it a simple one, check the appearance of
spark.sparkContext.hadoopConfiguration ?
Otherwise there are too many usage for the sparkContext.hadoopConfiguration
Member
|
LGTM |
|
Test build #93518 has finished for PR 21866 at commit
|
Member
|
retest this please |
|
Test build #93528 has finished for PR 21866 at commit
|
Member
|
retest this please |
1 similar comment
Member
|
retest this please |
Member
|
ok to test |
|
Test build #93536 has finished for PR 21866 at commit
|
Member
|
retest this please |
|
Test build #93541 has finished for PR 21866 at commit
|
Member
|
Thanks! Merged to master. |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…Id to spark-avro After rethinking on the artifactId, I think it should be `spark-avro` instead of `spark-sql-avro`, which is simpler, and consistent with the previous artifactId. I think we need to change it before Spark 2.4 release. Also a tiny change: use `spark.sessionState.newHadoopConf()` to get the hadoop configuration, thus the related hadoop configurations in SQLConf will come into effect. Unit test Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21866 from gengliangwang/avro_followup. (cherry picked from commit c44eb56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After rethinking on the artifactId, I think it should be
spark-avroinstead ofspark-sql-avro, which is simpler, and consistent with the previous artifactId. I think we need to change it before Spark 2.4 release.Also a tiny change: use
spark.sessionState.newHadoopConf()to get the hadoop configuration, thus the related hadoop configurations in SQLConf will come into effect.How was this patch tested?
Unit test