Skip to content

[SPARK-24768][FollowUp][SQL]Avro migration followup: change artifactId to spark-avro #21866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 1 commit into from
Closed

[SPARK-24768][FollowUp][SQL]Avro migration followup: change artifactId to spark-avro #21866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/avro/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>spark-sql-avro_2.11</artifactId>
<artifactId>spark-avro_2.11</artifactId>
<properties>
<sbt.project.name>avro</sbt.project.name>
</properties>
Expand Down
2 changes: 1 addition & 1 deletion external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ private[avro] class AvroFileFormat extends FileFormat with DataSourceRegister {
spark: SparkSession,
options: Map[String, String],
files: Seq[FileStatus]): Option[StructType] = {
val conf = spark.sparkContext.hadoopConfiguration
val conf = spark.sessionState.newHadoopConf()
Copy link
Member

@gatorsmile gatorsmile Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good catch!

Copy link
Contributor

@rxin rxin Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a linter rule for this?

Copy link
Member

@gatorsmile gatorsmile Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gengliangwang Please help this?

Copy link
Member Author

@gengliangwang gengliangwang Jul 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do it.
Can I make it a simple one, check the appearance of
spark.sparkContext.hadoopConfiguration ?
Otherwise there are too many usage for the sparkContext.hadoopConfiguration

val parsedOptions = new AvroOptions(options, conf)

// Schema evolution is not supported yet. Here we only pick a single random sample file to
Expand Down