[SPARK-23938][SQL][FOLLOW-UP][TEST] Nullabilities of value arguments should be true. #22126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
LGTM |
mn-mikke
reviewed
Aug 16, 2018
| val MapType(kt, vt1, vcn1) = left.dataType.asInstanceOf[MapType] | ||
| val MapType(_, vt2, vcn2) = right.dataType.asInstanceOf[MapType] | ||
| MapZipWith(left, right, createLambda(kt, false, vt1, vcn1, vt2, vcn2, f)) | ||
| val MapType(kt, vt1, _) = left.dataType.asInstanceOf[MapType] |
Contributor
There was a problem hiding this comment.
Optional suggestion: Maybe we could removeasInstanceOf[MapType] here?
|
Test build #94863 has finished for PR 22126 at commit
|
|
Test build #94871 has finished for PR 22126 at commit
|
Member
Author
|
Thanks! merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up pr of #22017 which added
map_zip_withfunction.In the test, when creating a lambda function, we use the
valueContainsNullvalues for the nullabilities of the value arguments, but we should've usedtrueas the same asbindmethod because the values might benullif the keys don't match.How was this patch tested?
Added small tests and existing tests.