Skip to content

[SPARK-23938][SQL][FOLLOW-UP][TEST] Nullabilities of value arguments should be true. #22126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 2 commits into from
Closed

[SPARK-23938][SQL][FOLLOW-UP][TEST] Nullabilities of value arguments should be true. #22126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c005109
Fix a test.
ueshin Aug 16, 2018
45d044c
Address a comment.
ueshin Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .../src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,9 +363,9 @@ class HigherOrderFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper
left: Expression,
right: Expression,
f: (Expression, Expression, Expression) => Expression): Expression = {
val MapType(kt, vt1, vcn1) = left.dataType.asInstanceOf[MapType]
val MapType(_, vt2, vcn2) = right.dataType.asInstanceOf[MapType]
MapZipWith(left, right, createLambda(kt, false, vt1, vcn1, vt2, vcn2, f))
val MapType(kt, vt1, _) = left.dataType
val MapType(_, vt2, _) = right.dataType
MapZipWith(left, right, createLambda(kt, false, vt1, true, vt2, true, f))
}

val mii0 = Literal.create(Map(1 -> 10, 2 -> 20, 3 -> 30),
Expand Down Expand Up @@ -402,6 +402,8 @@ class HigherOrderFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper
checkEvaluation(
map_zip_with(mii0, miin, multiplyKeyWithValues),
null)
assert(map_zip_with(mii0, mii1, multiplyKeyWithValues).dataType ===
MapType(IntegerType, IntegerType, valueContainsNull = true))

val mss0 = Literal.create(Map("a" -> "x", "b" -> "y", "d" -> "z"),
MapType(StringType, StringType, valueContainsNull = false))
Expand Down Expand Up @@ -437,6 +439,8 @@ class HigherOrderFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper
checkEvaluation(
map_zip_with(mss0, mssn, concat),
null)
assert(map_zip_with(mss0, mss1, concat).dataType ===
MapType(StringType, StringType, valueContainsNull = true))

def b(data: Byte*): Array[Byte] = Array[Byte](data: _*)

Expand Down