Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

Py4J 0.10.8.1 is released on October 21st and is the first release of Py4J to support Python 3.7 officially. We had better have this to get the official support. Also, there are some patches related to garbage collections.

https://www.py4j.org/changelog.html#py4j-0-10-8-and-py4j-0-10-8-1

How was this patch tested?

Pass the Jenkins.

@SparkQA
Copy link

SparkQA commented Oct 31, 2018

Test build #98304 has finished for PR 22901 at commit a76dc91.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Oct 31, 2018

Test build #98305 has finished for PR 22901 at commit a76dc91.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 31, 2018

That sounds like a good idea. I wonder if it's safe to back-port to 2.4/2.3? should be if it's just a maintenance release.

@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen . I think it's safe to backport. Previously, we backported Py4J 0.7 to 2.4/2.3/2.2/2.1 for security fixes. We need separate PRs per branch to trigger Jenkins.

After review, I'll merge this to master only since we are in the middle of voting RC5. For the rest, I'll try later.

@dongjoon-hyun
Copy link
Member Author

Hi, @HyukjinKwon and @BryanCutler . Could you review this PR, too?

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @BryanCutler .
Merged to master.

@asfgit asfgit closed this in e4cb42a Oct 31, 2018
@dongjoon-hyun dongjoon-hyun deleted the SPARK-25891 branch October 31, 2018 17:05
@HyukjinKwon
Copy link
Member

Late LGTM!

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

Py4J 0.10.8.1 is released on October 21st and is the first release of Py4J to support Python 3.7 officially. We had better have this to get the official support. Also, there are some patches related to garbage collections.

https://www.py4j.org/changelog.html#py4j-0-10-8-and-py4j-0-10-8-1

## How was this patch tested?

Pass the Jenkins.

Closes apache#22901 from dongjoon-hyun/SPARK-25891.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants