-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-25891][PYTHON] Upgrade to Py4J 0.10.8.1 #22924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-25891][PYTHON] Upgrade to Py4J 0.10.8.1 #22924
Conversation
## What changes were proposed in this pull request? Py4J 0.10.8.1 is released on October 21st and is the first release of Py4J to support Python 3.7 officially. We had better have this to get the official support. Also, there are some patches related to garbage collections. https://www.py4j.org/changelog.html#py4j-0-10-8-and-py4j-0-10-8-1 ## How was this patch tested? Pass the Jenkins. Closes #22901 from dongjoon-hyun/SPARK-25891. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Since 2.4.0 passed the vote, I think we can start to discuss this. This is for Spark 2.4.1 to support Python 3.7 more officially. @HyukjinKwon , @BryanCutler , @srowen , @cloud-fan , @gatorsmile . Could you guys give me some advice on this? And, do I need to change the JIRA issue types to a |
|
Test build #98361 has finished for PR 22924 at commit
|
|
I think it's OK to backport at 3.7 support is actually fairly important, and this also fixes bugs: https://www.py4j.org/changelog.html It drops 2.6 support but we did so as well a long time ago in 2.2.0. |
|
I am against this change in 2.4 branch unless the bugs are critical for our end users. |
|
Yeah I get that. I haven't heard the bugs that are fixed here impact users, but a few sound kind of bad. Maybe this should depend more on: how much do people need Python 3.7 in 2.4.x? that seems like a valid basis to back-port, if it were in demand. A 'bug fix' of a different sort, fixing incompatibilities with 3.7 |
|
I would be more conservative in these cases. The new release of Py4J might introduce new regressions. Not all the changes are clearly documented in their release notes. It is kind of aggressive to change the dependence in our maintenance releases. |
|
Thank you for your interests and discussion, @srowen and @gatorsmile . Thank you again. |
|
Test build #98362 has finished for PR 22924 at commit
|
|
Hi, |
|
I think it's fine to backport. @fabiencelier, as a workaround for now, you can install py4j 0.10.8.1 via pip and remove |
|
Hi, @fabiencelier and @HyukjinKwon . As the original author of this PR, I'm +1 for the backporting idea. However, as you see in the previous comments, this backporting was already considered and officially rejected by the community. (cc @gatorsmile ) For now, @HyukjinKwon 's workaround or Spark 3.0.0 will be the viable solutions. |
What changes were proposed in this pull request?
This is a backport of #22901.
Py4J 0.10.8.1 is released on October 21st and is the first release of Py4J to support Python 3.7 officially. We had better have this to get the official support. Also, there are some patches related to garbage collections.
https://www.py4j.org/changelog.html#py4j-0-10-8-and-py4j-0-10-8-1
How was this patch tested?
Pass the Jenkins.