[SPARK-29578][TESTS] Add "8634" as another skipped day for Kwajalein timzeone due to more recent timezone updates in later JDK 8 #26236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recent timezone updates in later JDK 8
| @@ -555,12 +555,12 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers { | |||
|
|
|||
| // There are some days are skipped entirely in some timezone, skip them here. | |||
| val skipped_days = Map[String, Set[Int]]( | |||
| "Kwajalein" -> Set(8632, 8633), | |||
| "Kwajalein" -> Set(8632, 8633, 8634), | |||
There was a problem hiding this comment.
Could you put the JDK / OS version for this into the PR description, please?
There was a problem hiding this comment.
I updated the JDK version. I'll ask the reporter to comment here with more details. That said, I think this is an obvious fix so I'm not too worried about those details. It doesn't happen on 1.8.0_222 at least.
There was a problem hiding this comment.
When we encountered, this test failed on jdk 1.8.0_232
There was a problem hiding this comment.
And, which OS did you used?
There was a problem hiding this comment.
I assume it's Linux @darshan-pandya but would it matter? Java uses its own TZ info rather than anything from the OS.
There was a problem hiding this comment.
Just out of curiosity, 😄 .
|
Test build #112565 has finished for PR 26236 at commit
|
HyukjinKwon
approved these changes
Oct 24, 2019
|
Merged to master |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Jan 29, 2020
…timzeone due to more recent timezone updates in later JDK 8 ### What changes were proposed in this pull request? Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones. ### Why are the changes needed? Keeps test passing on the latest JDK releases. ### Does this PR introduce any user-facing change? None ### How was this patch tested? Existing tests Closes apache#26236 from srowen/SPARK-29578. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 30, 2020
…lein timzeone due to more recent timezone updates in later JDK 8 (Backport of #26236) ### What changes were proposed in this pull request? Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones. ### Why are the changes needed? Keeps test passing on the latest JDK releases. ### Does this PR introduce any user-facing change? None ### How was this patch tested? Existing tests Closes #27386 from srowen/SPARK-29578.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 8, 2020
…timzeone due to more recent timezone updates in later JDK 8 Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones. Keeps test passing on the latest JDK releases. None Existing tests Closes apache#26236 from srowen/SPARK-29578. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 20, 2020
…timzeone due to more recent timezone updates in later JDK 8 Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones. Keeps test passing on the latest JDK releases. None Existing tests Closes apache#26236 from srowen/SPARK-29578. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
May 1, 2020
…timzeone due to more recent timezone updates in later JDK 8 Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones. Keeps test passing on the latest JDK releases. None Existing tests Closes apache#26236 from srowen/SPARK-29578. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
May 1, 2020
…timzeone due to more recent timezone updates in later JDK 8 Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones. Keeps test passing on the latest JDK releases. None Existing tests Closes apache#26236 from srowen/SPARK-29578. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones.
Why are the changes needed?
Keeps test passing on the latest JDK releases.
Does this PR introduce any user-facing change?
None
How was this patch tested?
Existing tests