Skip to content

Commit

Permalink
[SPARK-29578][TESTS] Add "8634" as another skipped day for Kwajalein …
Browse files Browse the repository at this point in the history
…timzeone due to more recent timezone updates in later JDK 8

Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones.

Keeps test passing on the latest JDK releases.

None

Existing tests

Closes apache#26236 from srowen/SPARK-29578.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
  • Loading branch information
srowen authored and rshkv committed May 1, 2020
1 parent 95c106c commit 87a55df
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -688,12 +688,12 @@ class DateTimeUtilsSuite extends SparkFunSuite {

// There are some days are skipped entirely in some timezone, skip them here.
val skipped_days = Map[String, Set[Int]](
"Kwajalein" -> Set(8632),
"Kwajalein" -> Set(8632, 8633, 8634),
"Pacific/Apia" -> Set(15338),
"Pacific/Enderbury" -> Set(9130, 9131),
"Pacific/Fakaofo" -> Set(15338),
"Pacific/Kiritimati" -> Set(9130, 9131),
"Pacific/Kwajalein" -> Set(8632),
"Pacific/Kwajalein" -> Set(8632, 8633, 8634),
"MIT" -> Set(15338))
for (tz <- DateTimeTestUtils.ALL_TIMEZONES) {
val skipped = skipped_days.getOrElse(tz.getID, Set.empty)
Expand Down

0 comments on commit 87a55df

Please sign in to comment.