[SPARK-29486][SQL][FOLLOWUP] Document the reason to add days field #26701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
srowen
reviewed
Nov 28, 2019
Member
There was a problem hiding this comment.
Previous -> Previously,
has -> had
Nit: I don't know if it matters to talk about the previous implementation. A note about why days exist is fine.
Frankly it might also be worth a note about why months exists at all (they are also not units of time with a constant length, unlike hours, minutes, seconds)
Contributor
Author
There was a problem hiding this comment.
@srowen thanks for your suggestion, I changed another way to note about the reason. Could you review again?
LinhongLiu
force-pushed
the
spark-29486-followup
branch
from
d6d572b to
114eb37
Compare
srowen
approved these changes
Nov 29, 2019
|
Test build #4949 has finished for PR 26701 at commit
|
Member
|
Merged to master |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Dec 6, 2019
### What changes were proposed in this pull request? Follow up of apache#26134 to document the reason to add days filed and explain how do we use it ### Why are the changes needed? only comment ### Does this PR introduce any user-facing change? no ### How was this patch tested? no need test Closes apache#26701 from LinhongLiu/spark-29486-followup. Authored-by: Liu,Linhong <liulinhong@baidu.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow up of #26134 to document the reason to add days filed and explain how do we use it
Why are the changes needed?
only comment
Does this PR introduce any user-facing change?
no
How was this patch tested?
no need test