Skip to content

[SPARK-29486][SQL][FOLLOWUP] Document the reason to add days field #26701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LinhongLiu wants to merge 2 commits into from
Closed

[SPARK-29486][SQL][FOLLOWUP] Document the reason to add days field #26701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8890595
[SPARK-29486][SQL][FOLLOWUP] Document the reason to add days field
LinhongLiu Nov 28, 2019
114eb37
change another way to explain
LinhongLiu Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ public final class CalendarInterval implements Serializable, Comparable<Calendar
public final int days;
public final long microseconds;

// CalendarInterval is represented by months, days and microseconds. Months and days are not
// units of time with a constant length (unlike hours, seconds), so they are two separated fields
// from microseconds. One month may be equal to 29, 30 or 31 days and one day may be equal to
// 23, 24 or 25 hours (daylight saving)
public CalendarInterval(int months, int days, long microseconds) {
this.months = months;
this.days = days;
Expand Down