[SPARK-3814][SQL] Bitwise & does not work in Hive #2710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
|
Test FAILed. |
Contributor
Author
|
@marmbrus it seems git cannot fetch the code that's why it is failed. |
Contributor
|
Yeah, sorry github seems extra flakey today. Now there is a conflict though, could you merge with master? |
Contributor
Author
|
I am closing this PR as it has conflicts. And I created new PR #2736 |
Contributor
|
@ravipesala, you don't need to create a new PR. And in fact its better if you don't so review comments are not lost. You can just push to the same branch and github will update this PR. You can even push a totally different version to a branch of the same name with |
hvanhovell
pushed a commit
that referenced
this pull request
Aug 23, 2019
…d for easier identifying their reuses in query plans ## What changes were proposed in this pull request? Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans, for example: ``` ReusedExchange d_date_sk#827, BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint))) [id=#2710] ``` Where `2710` is the id of the reused exchange. ## How was this patch tested? Passes existing tests Closes #25434 from dbaliafroozeh/ImplementStringArgsExchangeSubqueryExec. Authored-by: Ali Afroozeh <ali.afroozeh@databricks.com> Signed-off-by: herman <herman@databricks.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Jan 29, 2021
…d for easier identifying their reuses in query plans Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans, for example: ``` ReusedExchange d_date_sk#827, BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint))) [id=apache#2710] ``` Where `2710` is the id of the reused exchange. Passes existing tests Closes apache#25434 from dbaliafroozeh/ImplementStringArgsExchangeSubqueryExec. Authored-by: Ali Afroozeh <ali.afroozeh@databricks.com> Signed-off-by: herman <herman@databricks.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Jan 29, 2021
…d for easier identifying their reuses in query plans Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans, for example: ``` ReusedExchange d_date_sk#827, BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint))) [id=apache#2710] ``` Where `2710` is the id of the reused exchange. Passes existing tests Closes apache#25434 from dbaliafroozeh/ImplementStringArgsExchangeSubqueryExec. Authored-by: Ali Afroozeh <ali.afroozeh@databricks.com> Signed-off-by: herman <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no support of Bitwise & in Spark HiveQl and Spark SQL as well. So this PR support the same.
Author : ravipesala ravindra.pesala@huawei.com