-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3814][SQL] Bitwise & does not work in Hive #2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
|
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the standard Scala numeric doesn't support the operation, I think I'd prefer we just put the logic in the expression's eval function. Otherwise I'm afraid the types will get too unwieldy.
|
A few other comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BitwiseAnd
|
Since this PR has conflicts , I created new PR #2772 and handled review comments in it. |
|
Hi, @ravipesala, you don't need create a new PR, you can update you pr here(use git push to update this branch) |
|
Thank you @scwf , I have created new PR since it has merge conflicts. It will not be neat If I rebase and push to old PR because it will show all changed files which are merged while rebasing. |
|
I don't think that is correct. Github shows whatever the difference is between the head commit of the PR branch and apache/master. Intermediate changes/merges should not show up. Also our merge script squashes all commits to a single commit when we actually add code to master, so it really doesn't matter if there are other things in the middle. |
Currently there is no support of Bitwise & in Spark HiveQl and Spark SQL as well. So this PR support the same.
I am closing #2710 as it has conflicts to merge
Author : ravipesala ravindra.pesala@huawei.com