Skip to content

Conversation

@ravipesala
Copy link
Contributor

Currently there is no support of Bitwise & in Spark HiveQl and Spark SQL as well. So this PR support the same.
I am closing #2710 as it has conflicts to merge

Author : ravipesala ravindra.pesala@huawei.com

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

marmbrus commented Oct 9, 2014

ok to test

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21551/Test FAILed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the standard Scala numeric doesn't support the operation, I think I'd prefer we just put the logic in the expression's eval function. Otherwise I'm afraid the types will get too unwieldy.

@marmbrus
Copy link
Contributor

A few other comments:

  • Would it be possible to support bitwise or as well since that code will be very similar?
  • New expressions should have tests in ExpressionEvaluationSuite as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BitwiseAnd

@ravipesala
Copy link
Contributor Author

Since this PR has conflicts , I created new PR #2772 and handled review comments in it.

@ravipesala ravipesala closed this Oct 11, 2014
@scwf
Copy link
Contributor

scwf commented Oct 12, 2014

Hi, @ravipesala, you don't need create a new PR, you can update you pr here(use git push to update this branch)

@ravipesala
Copy link
Contributor Author

Thank you @scwf , I have created new PR since it has merge conflicts. It will not be neat If I rebase and push to old PR because it will show all changed files which are merged while rebasing.

@marmbrus
Copy link
Contributor

I don't think that is correct. Github shows whatever the difference is between the head commit of the PR branch and apache/master. Intermediate changes/merges should not show up. Also our merge script squashes all commits to a single commit when we actually add code to master, so it really doesn't matter if there are other things in the middle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants