Skip to content

Conversation

@JQ-Cao
Copy link

@JQ-Cao JQ-Cao commented Nov 25, 2020

What changes were proposed in this pull request?

display the jvm peak memory usage on the executors page to help user tune "spark.executor.memory" and "spark.executor.memoryOverhead"

Why are the changes needed?

Peak Execution Memory can only be obtained through restAPI and cannot be displayed on Spark Executors UI intuitively,
although spark users tune spark executor memory are dependent on the metrics. Therefore, it is very important to display the peak memory usage on the spark UI.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

The pr only involves minor changes to the page and does not affect other functions,
The manual test results are as follows.

image

…r ui

display the jvm peak memory usage on the executors page to help user tune "spark.executor.memory" and "spark.executor.memoryOverhead"

Peak Execution Memory can only be obtained through restAPI and cannot be displayed on Spark Executors UI intuitively,
although spark users tune spark executor memory are dependent on the metrics. Therefore, it is very important to display the peak memory usage on the spark UI.

NO
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@luluorta
Copy link
Contributor

cc @cloud-fan
Please review this patch, many thanks!

@HyukjinKwon
Copy link
Member

cc @gengliangwang and @sarutak FYI

@gengliangwang
Copy link
Member

@JQ-Cao These metrics are already on the executor page. They will show up after select the additional metrics checkbox:
image

@gengliangwang
Copy link
Member

BTW, the style of the screenshot is messy. I just created #30500 to fix it.

@JQ-Cao
Copy link
Author

JQ-Cao commented Nov 26, 2020

@JQ-Cao These metrics are already on the executor page. They will show up after select the additional metrics checkbox:
image

yes, i find it, thanks

@JQ-Cao JQ-Cao closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants