[SPARK-33562][UI] Improve the style of the checkbox in executor page #30500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #131788 has finished for PR 30500 at commit
|
tgravescs
approved these changes
Nov 25, 2020
Contributor
tgravescs
left a comment
tgravescs
left a comment
There was a problem hiding this comment.
changes look fine. I can't think of anything remove the limit would break.
sarutak
approved these changes
Nov 26, 2020
HyukjinKwon
approved these changes
Nov 26, 2020
Member
|
Merged to master. |
Member
|
@gengliangwang, do you want to port this back? It has a conflict to resolve so I didn't port it back for now. I will leave it to you to port it back after resolving the conflicts. |
Member
Author
|
@HyukjinKwon I just found that the issue doesn't exist until #30186. Before that the text was short. |
Member
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
container-fluid-div. So that the UI looks clean when the text is long.Why are the changes needed?
The width of class
container-fluid-divis set as 200px after #21688 . This makes the checkbox in the executor page messy.We should remove the width limit.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual test.
After the changes: