Skip to content

[SPARK-4390][SQL] Handle NaN cast to decimal correctly #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marmbrus wants to merge 2 commits into from
Closed

[SPARK-4390][SQL] Handle NaN cast to decimal correctly #3256

marmbrus wants to merge 2 commits into from

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Nov 13, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Nov 13, 2014

Test build #23335 has started for PR 3256 at commit d360f83.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 13, 2014

Test build #23335 has finished for PR 3256 at commit d360f83.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 13, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23335/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23341 has started for PR 3256 at commit 4c3ba46.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23341 has finished for PR 3256 at commit 4c3ba46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23341/
Test PASSed.

asfgit pushed a commit that referenced this pull request Nov 14, 2014
@marmbrus
[SPARK-4390][SQL] Handle NaN cast to decimal correctly
0dd9241 
Author: Michael Armbrust <michael@databricks.com>

Closes #3256 from marmbrus/NanDecimal and squashes the following commits:

4c3ba46 [Michael Armbrust] fix style
d360f83 [Michael Armbrust] Handle NaN cast to decimal

(cherry picked from commit a0300ea)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in a0300ea Nov 14, 2014
@ueshin ueshin mentioned this pull request Nov 15, 2014
Closed
asfgit pushed a commit that referenced this pull request Nov 18, 2014
@ueshin @marmbrus
[SPARK-4420][SQL] Change nullability of Cast from DoubleType/FloatTyp…
3a81a1c 
…e to DecimalType.

This is follow-up of [SPARK-4390](https://issues.apache.org/jira/browse/SPARK-4390) (#3256).

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #3278 from ueshin/issues/SPARK-4420 and squashes the following commits:

7fea558 [Takuya UESHIN] Add some tests.
cb2301a [Takuya UESHIN] Fix tests.
133bad5 [Takuya UESHIN] Change nullability of Cast from DoubleType/FloatType to DecimalType.
asfgit pushed a commit that referenced this pull request Nov 18, 2014
@ueshin @marmbrus
[SPARK-4420][SQL] Change nullability of Cast from DoubleType/FloatTyp…
1ca39b7 
…e to DecimalType.

This is follow-up of [SPARK-4390](https://issues.apache.org/jira/browse/SPARK-4390) (#3256).

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #3278 from ueshin/issues/SPARK-4420 and squashes the following commits:

7fea558 [Takuya UESHIN] Add some tests.
cb2301a [Takuya UESHIN] Fix tests.
133bad5 [Takuya UESHIN] Change nullability of Cast from DoubleType/FloatType to DecimalType.

(cherry picked from commit 3a81a1c)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus marmbrus deleted the NanDecimal branch November 19, 2014 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marmbrus @SparkQA @AmplabJenkins