Skip to content

[SPARK-4420][SQL] Change nullability of Cast from DoubleType/FloatType to DecimalType. #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ueshin wants to merge 3 commits into from
Closed

[SPARK-4420][SQL] Change nullability of Cast from DoubleType/FloatType to DecimalType. #3278

ueshin wants to merge 3 commits into from

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Nov 15, 2014

This is follow-up of SPARK-4390 (#3256).

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23411 has started for PR 3278 at commit 133bad5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23411 has finished for PR 3278 at commit 133bad5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 15, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23411/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23412 has started for PR 3278 at commit cb2301a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23412 has finished for PR 3278 at commit cb2301a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 15, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23412/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23416 has started for PR 3278 at commit 7fea558.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23416 has finished for PR 3278 at commit 7fea558.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 15, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23416/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Nov 18, 2014

Thanks! Merged to master and 1.2

@asfgit asfgit closed this in 3a81a1c Nov 18, 2014
asfgit pushed a commit that referenced this pull request Nov 18, 2014
@ueshin @marmbrus
[SPARK-4420][SQL] Change nullability of Cast from DoubleType/FloatTyp…
1ca39b7 
…e to DecimalType.

This is follow-up of [SPARK-4390](https://issues.apache.org/jira/browse/SPARK-4390) (#3256).

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #3278 from ueshin/issues/SPARK-4420 and squashes the following commits:

7fea558 [Takuya UESHIN] Add some tests.
cb2301a [Takuya UESHIN] Fix tests.
133bad5 [Takuya UESHIN] Change nullability of Cast from DoubleType/FloatType to DecimalType.

(cherry picked from commit 3a81a1c)
Signed-off-by: Michael Armbrust <michael@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ueshin @SparkQA @AmplabJenkins @marmbrus