Skip to content

[SPARK-4420][SQL] Change nullability of Cast from DoubleType/FloatType to DecimalType. #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 3 commits into from
Closed

[SPARK-4420][SQL] Change nullability of Cast from DoubleType/FloatType to DecimalType. #3278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
133bad5
Change nullability of Cast from DoubleType/FloatType to DecimalType.
ueshin Nov 15, 2014
cb2301a
Fix tests.
ueshin Nov 15, 2014
7fea558
Add some tests.
ueshin Nov 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ case class Cast(child: Expression, dataType: DataType) extends UnaryExpression w
case (BooleanType, DateType) => true
case (DateType, _: NumericType) => true
case (DateType, BooleanType) => true
case (DoubleType, _: DecimalType) => true
case (FloatType, _: DecimalType) => true
case (_, DecimalType.Fixed(_, _)) => true // TODO: not all upcasts here can really give null
case _ => child.nullable
}
Expand Down
14 changes: 12 additions & 2 deletions .../src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,8 @@ class ExpressionEvaluationSuite extends FunSuite {
// - Because of this, casts to fixed-precision decimals should be nullable

assert(Cast(Literal(123), DecimalType.Unlimited).nullable === false)
assert(Cast(Literal(10.03f), DecimalType.Unlimited).nullable === false)
assert(Cast(Literal(10.03), DecimalType.Unlimited).nullable === false)
assert(Cast(Literal(10.03f), DecimalType.Unlimited).nullable === true)
assert(Cast(Literal(10.03), DecimalType.Unlimited).nullable === true)
assert(Cast(Literal(Decimal(10.03)), DecimalType.Unlimited).nullable === false)

assert(Cast(Literal(123), DecimalType(2, 1)).nullable === true)
Expand Down Expand Up @@ -396,6 +396,16 @@ class ExpressionEvaluationSuite extends FunSuite {
checkEvaluation(Cast(Literal(-9.95), DecimalType(1, 0)), null)
checkEvaluation(Cast(Literal(Decimal(-9.95)), DecimalType(3, 1)), Decimal(-10.0))
checkEvaluation(Cast(Literal(Decimal(-9.95)), DecimalType(1, 0)), null)

checkEvaluation(Cast(Literal(Double.NaN), DecimalType.Unlimited), null)
checkEvaluation(Cast(Literal(1.0 / 0.0), DecimalType.Unlimited), null)
checkEvaluation(Cast(Literal(Float.NaN), DecimalType.Unlimited), null)
checkEvaluation(Cast(Literal(1.0f / 0.0f), DecimalType.Unlimited), null)

checkEvaluation(Cast(Literal(Double.NaN), DecimalType(2, 1)), null)
checkEvaluation(Cast(Literal(1.0 / 0.0), DecimalType(2, 1)), null)
checkEvaluation(Cast(Literal(Float.NaN), DecimalType(2, 1)), null)
checkEvaluation(Cast(Literal(1.0f / 0.0f), DecimalType(2, 1)), null)
}

test("timestamp") {
Expand Down