-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors #34695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3bacabd
[SPARK-32446][SHS] Add percentile distribution REST API of peak memor…
AngersZhuuuu fa685bf
Add UI stelp 1
AngersZhuuuu a51b4e8
Merge branch 'master' into SPARK-32446
AngersZhuuuu 27ab858
Update executorspage.js
AngersZhuuuu b01750e
Update executorspage.js
AngersZhuuuu d74f909
Update executorspage.js
AngersZhuuuu b2a4289
Update executorspage.js
AngersZhuuuu 5e12e0c
Fix JS format
AngersZhuuuu 415981f
Merge branch 'master' into SPARK-32446
AngersZhuuuu aa207af
update
AngersZhuuuu 0ffdbb8
Update executorspage.js
AngersZhuuuu b08a77d
Update executor_peak_memory_metrics_distributions_expectation.json
AngersZhuuuu 718c7d3
Update executorspage.js
AngersZhuuuu 52c920c
Update executorspage.js
AngersZhuuuu b2d6e50
Merge branch 'master' into SPARK-32446
AngersZhuuuu 34e1bf7
Update executorspage.js
AngersZhuuuu 247985b
Merge branch 'master' into SPARK-32446
AngersZhuuuu 8ca2156
Update executorspage.js
AngersZhuuuu 1f276df
Update executorspage.js
AngersZhuuuu 343e178
Update executorspage.js
AngersZhuuuu c7b5ad8
Update executorspage.js
AngersZhuuuu 13d0981
trigger
AngersZhuuuu c567c57
Merge branch 'master' into SPARK-32446
AngersZhuuuu edec1a5
Update executorspage.js
AngersZhuuuu 98c1ec7
Update executorspage.js
AngersZhuuuu 2ef92fd
Update executorspage.js
AngersZhuuuu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
318 changes: 307 additions & 11 deletions
318
core/src/main/resources/org/apache/spark/ui/static/executorspage.js
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...ces/HistoryServerExpectations/executor_peak_memory_metrics_distributions_expectation.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "JVMHeapMemory" : [ 2.09883992E8, 4.6213568E8, 7.5947948E8, 9.8473656E8, 9.8473656E8 ], | ||
| "JVMOffHeapMemory" : [ 6.0829472E7, 6.1343616E7, 6.271752E7, 9.1926448E7, 9.1926448E7 ], | ||
| "OnHeapExecutionMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "OffHeapExecutionMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "OnHeapStorageMemory" : [ 7023.0, 12537.0, 19560.0, 19560.0, 19560.0 ], | ||
| "OffHeapStorageMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "OnHeapUnifiedMemory" : [ 7023.0, 12537.0, 19560.0, 19560.0, 19560.0 ], | ||
| "OffHeapUnifiedMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "DirectPoolMemory" : [ 10742.0, 10865.0, 12781.0, 157182.0, 157182.0 ], | ||
| "MappedPoolMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "ProcessTreeJVMVMemory" : [ 8.296026112E9, 9.678606336E9, 9.684373504E9, 9.691553792E9, 9.691553792E9 ], | ||
| "ProcessTreeJVMRSSMemory" : [ 5.26491648E8, 7.03639552E8, 9.64222976E8, 1.210867712E9, 1.210867712E9 ], | ||
| "ProcessTreePythonVMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "ProcessTreePythonRSSMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "ProcessTreeOtherVMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "ProcessTreeOtherRSSMemory" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ], | ||
| "MinorGCCount" : [ 7.0, 15.0, 24.0, 27.0, 27.0 ], | ||
| "MinorGCTime" : [ 55.0, 106.0, 140.0, 145.0, 145.0 ], | ||
| "MajorGCCount" : [ 2.0, 2.0, 2.0, 3.0, 3.0 ], | ||
| "MajorGCTime" : [ 60.0, 63.0, 75.0, 144.0, 144.0 ], | ||
| "TotalGCTime" : [ 0.0, 0.0, 0.0, 0.0, 0.0 ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like most of the logic here is duplicated with
createRESTEndPointForExecutorsPageexcept for the REST call. Can we refactor it a bit and avoid/reduce the redundant code?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It belongs to different api,
allexecutorsreturn the list of all executor's summaries. It's hard to combine/allexecutorsand/executorPeakMemoryMetricsDistributionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about current.