-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-39332][BUILD] Upgrade RoaringBitmap to 0.9.28 #36719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @LuciferYang .
Could you run MapStatusesSerDeserBenchmark like #29233?
ok |
|
3da048a update bench result of
need to re-run to keep them the same @dongjoon-hyun ? |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @LuciferYang .
The difference is okay because we cannot control it.
Merged to master for Apache Spark 3.4.
@dongjoon-hyun Sorry to bother you, I used It seems that spark/core/src/test/scala/org/apache/spark/MapStatusesSerDeserBenchmark.scala Lines 56 to 62 in 57c82ea
|
|
Thank you for pinging me, @LuciferYang . Let me check it. |
|
Oh, you are right. Sorry for misleading you so far, @LuciferYang . :( |
doesn't matter ~ :) |
What changes were proposed in this pull request?
This pr aims upgrade
RoaringBitmapto 0.9.28Why are the changes needed?
This version bring bug fix and optimization, for example, andCardinality/orCardinality without materialising a bitmap, optimized
andCardinality/orCardinalityperformance.The changes between 0.9.25 and 0.9.28 as follows:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Github Actions