Skip to content

[SPARK-40740][SQL] Improve listFunctions in SessionCatalog #38194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
allisonwang-db wants to merge 1 commit into from
Closed

[SPARK-40740][SQL] Improve listFunctions in SessionCatalog #38194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,11 +1784,11 @@ class SessionCatalog(
}

/**
* List all registered functions in a database with the given pattern.
* List all built-in and temporary functions with the given pattern.
*/
private def listRegisteredFunctions(db: String, pattern: String): Seq[FunctionIdentifier] = {
private def listBuiltinAndTempFunctions(pattern: String): Seq[FunctionIdentifier] = {
val functions = (functionRegistry.listFunction() ++ tableFunctionRegistry.listFunction())
.filter(_.database.forall(_ == db))
.filter(_.database.isEmpty)
StringUtils.filterPattern(functions.map(_.unquotedString), pattern).map { f =>
// In functionRegistry, function names are stored as an unquoted format.
Try(parser.parseFunctionIdentifier(f)) match {
Expand Down Expand Up @@ -1817,7 +1817,7 @@ class SessionCatalog(
requireDbExists(dbName)
val dbFunctions = externalCatalog.listFunctions(dbName, pattern).map { f =>
FunctionIdentifier(f, Some(dbName)) }
val loadedFunctions = listRegisteredFunctions(db, pattern)
val loadedFunctions = listBuiltinAndTempFunctions(pattern)
val functions = dbFunctions ++ loadedFunctions
// The session catalog caches some persistent functions in the FunctionRegistry
// so there can be duplicates.
Expand Down