[SPARK-42241][CONNECT][TESTS] Fix the find connect jar condition in SparkConnectServerUtils#findSparkConnectJar for maven
#39810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
SparkConnectServerUtils#findSparkConnectJar to find the correct connect server jar for mavenSparkConnectServerUtils#findSparkConnectJar for maven
Contributor
Author
|
https://github.com/LuciferYang/spark/actions/runs/4046025224/jobs/6958308503 cc @HyukjinKwon when I do some maven test work using GA, I found the original condition may found wrong connect jar for maven |
LuciferYang
changed the title
SparkConnectServerUtils#findSparkConnectJar for mavenSparkConnectServerUtils#findSparkConnectJar for maven
LuciferYang
changed the title
SparkConnectServerUtils#findSparkConnectJar for mavenSparkConnectServerUtils#findSparkConnectJar for maven
HyukjinKwon
approved these changes
Jan 31, 2023
Member
|
Merged to master and branch-3.4. @LuciferYang would you mind telling me the order that you want for merging your PRs? |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 31, 2023
…SparkConnectServerUtils#findSparkConnectJar` for maven ### What changes were proposed in this pull request? This pr aims to fix the finding connect jar condition in `SparkConnectServerUtils#findSparkConnectJar` to ensure the correct connect jar is found for maven test ### Why are the changes needed? After run ``` build/mvn -DskipTests clean install -pl connector/connect/server ``` or ``` build/mvn -DskipTests clean package -pl connector/connect/server ``` There will be 5 jars that meet the original conditions for maven: ``` spark-connect_2.12-3.5.0-SNAPSHOT-javadoc.jar spark-connect_2.12-3.5.0-SNAPSHOT-sources.jar spark-connect_2.12-3.5.0-SNAPSHOT-test-sources.jar spark-connect_2.12-3.5.0-SNAPSHOT-tests.jar spark-connect_2.12-3.5.0-SNAPSHOT.jar ``` and the head may not `spark-connect_2.12-3.5.0-SNAPSHOT.jar`, so need to make the condition more strictly to ensure that `spark-connect_2.12-3.5.0-SNAPSHOT.jar` is found ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions Closes #39810 from LuciferYang/SPARK-42241. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a98ac25) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Contributor
Author
|
Thanks @HyukjinKwon I hope #39789 can be merged first, which seems to be blocking version release |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…SparkConnectServerUtils#findSparkConnectJar` for maven ### What changes were proposed in this pull request? This pr aims to fix the finding connect jar condition in `SparkConnectServerUtils#findSparkConnectJar` to ensure the correct connect jar is found for maven test ### Why are the changes needed? After run ``` build/mvn -DskipTests clean install -pl connector/connect/server ``` or ``` build/mvn -DskipTests clean package -pl connector/connect/server ``` There will be 5 jars that meet the original conditions for maven: ``` spark-connect_2.12-3.5.0-SNAPSHOT-javadoc.jar spark-connect_2.12-3.5.0-SNAPSHOT-sources.jar spark-connect_2.12-3.5.0-SNAPSHOT-test-sources.jar spark-connect_2.12-3.5.0-SNAPSHOT-tests.jar spark-connect_2.12-3.5.0-SNAPSHOT.jar ``` and the head may not `spark-connect_2.12-3.5.0-SNAPSHOT.jar`, so need to make the condition more strictly to ensure that `spark-connect_2.12-3.5.0-SNAPSHOT.jar` is found ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions Closes apache#39810 from LuciferYang/SPARK-42241. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a98ac25) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to fix the finding connect jar condition in
SparkConnectServerUtils#findSparkConnectJarto ensure the correct connect jar is found for maven testWhy are the changes needed?
After run
or
There will be 5 jars that meet the original conditions for maven:
and the head may not
spark-connect_2.12-3.5.0-SNAPSHOT.jar, so need to make the condition more strictly to ensure thatspark-connect_2.12-3.5.0-SNAPSHOT.jaris foundDoes this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions