[SPARK-42323][SQL] Assign name to _LEGACY_ERROR_TEMP_2332
#39977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
changed the title
_LEGACY_ERROR_TEMP_2332
Contributor
Author
MaxGekk
reviewed
Feb 13, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
Outdated
Show resolved
Hide resolved
srielau
approved these changes
Feb 13, 2023
MaxGekk
approved these changes
Feb 19, 2023
Member
cloud-fan
reviewed
Aug 4, 2023
| messageParameters = Map("msg" -> e.getMessage), | ||
| cause = e) | ||
| errorClass = "UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY", | ||
| messageParameters = Map("dataSourceType" -> u.multipartIdentifier.head), |
Contributor
There was a problem hiding this comment.
this is not just assigning an error class name, but changing the error message as well. It's good to put the data source type in the error message, but I don't think we can simply ignore the original error message e.getMessage. @itholic can you fix it?
Contributor
There was a problem hiding this comment.
Please fix it before 3.5, as it's a regression
Contributor
Author
There was a problem hiding this comment.
Oh, seems like the #42124 already fixes the bug from UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY ??
Contributor
There was a problem hiding this comment.
are you sure? I don't see it passing the original error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_2332, "UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY".
Why are the changes needed?
We should assign proper name to LEGACY_ERROR_TEMP*
Does this PR introduce any user-facing change?
No
How was this patch tested?
./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*