Skip to content

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Jul 24, 2023

What changes were proposed in this pull request?

  1. UNSUPPORTED_DATA_SOURCE_FOR_DIRECT_QUERY is duplicated with UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY. This PR uses the shorter one.

  2. Bugfix for hiding root AE from UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY

Why are the changes needed?

UNSUPPORTED_DATA_SOURCE_FOR_DIRECT_QUERY is duplicated.

Bugfix for hiding root AE from UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY

For example,

 select id from parquet.`abc`;

[UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY] Unsupported data source type for direct query on files: parquet; line 1 pos 15
org.apache.spark.sql.AnalysisException: [UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY] Unsupported data source type for direct query on files: parquet; line 1 pos 15

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

…T_QUERY with UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY
@yaooqinn yaooqinn requested a review from cloud-fan July 24, 2023 08:30
@yaooqinn yaooqinn changed the title [SPARK-44520][SQL] Replace the term UNSUPPORTED_DATA_SOURCE_FOR_DIRECT_QUERY with UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY [SPARK-44520][SQL] Replace the term UNSUPPORTED_DATA_SOURCE_FOR_DIRECT_QUERY with UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY and disclosure root AE Jul 24, 2023
@yaooqinn yaooqinn closed this in 2f7a9a1 Jul 25, 2023
yaooqinn added a commit that referenced this pull request Jul 25, 2023
…T_QUERY with UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY and disclosure root AE

### What changes were proposed in this pull request?

1. UNSUPPORTED_DATA_SOURCE_FOR_DIRECT_QUERY is duplicated with UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY. This PR uses the shorter one.

2. Bugfix for hiding root AE from UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY

### Why are the changes needed?

UNSUPPORTED_DATA_SOURCE_FOR_DIRECT_QUERY is duplicated.

Bugfix for hiding root AE from UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY

For example,

```scala
 select id from parquet.`abc`;

[UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY] Unsupported data source type for direct query on files: parquet; line 1 pos 15
org.apache.spark.sql.AnalysisException: [UNSUPPORTED_DATASOURCE_FOR_DIRECT_QUERY] Unsupported data source type for direct query on files: parquet; line 1 pos 15
```

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests

Closes #42124 from yaooqinn/SPARK-44520.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
(cherry picked from commit 2f7a9a1)
Signed-off-by: Kent Yao <yao@apache.org>
@yaooqinn
Copy link
Member Author

thanks, merged to master and 3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants