[WIP][CONNECT] Initial runtime SQL configuration implementation #39995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
connect_config
branch
from
dbda1d7 to
e3a625d
Compare
zhengruifeng
changed the title
zhengruifeng
force-pushed
the
connect_config
branch
2 times, most recently
from
f8bd91f to
ed724cf
Compare
zhengruifeng
force-pushed
the
connect_config
branch
2 times, most recently
from
875f4fb to
1bba128
Compare
zhengruifeng
force-pushed
the
connect_config
branch
from
1bba128 to
fd1f764
Compare
Comment on lines
+199
to
+212
| // (Optional) | ||
| // | ||
| // Identify which keys will be updated or fetched. | ||
| // Required when the 'operation' is 'SET', 'GET', 'GET_OPTION', 'UNSET', | ||
| // 'CONTAINS', 'IS_MODIFIABLE'. | ||
| repeated string keys = 4; | ||
|
|
||
| // (Optional) | ||
| // | ||
| // Corresponding values to the keys. | ||
| // Required when the 'operation' is 'SET'. | ||
| // Optional when the 'operation' is 'GET', the values here will be used | ||
| // as the default values. | ||
| repeated string values = 5; |
Contributor
There was a problem hiding this comment.
why not make this something like this
repeated KeyValue pair = 4;
message KeyValue {
string key = 1;
string value = 2;
}
Contributor
There was a problem hiding this comment.
I find the reuse in case of GET/SET hard to reason about
| } | ||
|
|
||
| // Request to update or fetch the configurations. | ||
| message ConfigRequest { |
Contributor
There was a problem hiding this comment.
maybe more like
message ConfigRequest {
oneof type {
GetConfig get_config = 1;
SetConfig set_config = 2;
}
message GetConfig {
repeated string keys = 1;
}
message SetConfig {
repeated KeyValue pairs = 1;
}
}
Contributor
There was a problem hiding this comment.
I think it might be good to have explicit messages rather than the combination of the enum plus the message attributes.
Member
|
cc @ueshin |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 25, 2023
### What changes were proposed in this pull request? Implements `SparkSession.conf`. Took #39995 over. ### Why are the changes needed? `SparkSession.conf` is a missing feature. ### Does this PR introduce _any_ user-facing change? Yes, `SparkSession.conf` will be available. ### How was this patch tested? Added/enabled related tests. Closes #40150 from ueshin/issues/SPARK-41834/conf. Lead-authored-by: Takuya UESHIN <ueshin@databricks.com> Co-authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 25, 2023
Implements `SparkSession.conf`. Took #39995 over. `SparkSession.conf` is a missing feature. Yes, `SparkSession.conf` will be available. Added/enabled related tests. Closes #40150 from ueshin/issues/SPARK-41834/conf. Lead-authored-by: Takuya UESHIN <ueshin@databricks.com> Co-authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 47951c9) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
Implements `SparkSession.conf`. Took apache#39995 over. `SparkSession.conf` is a missing feature. Yes, `SparkSession.conf` will be available. Added/enabled related tests. Closes apache#40150 from ueshin/issues/SPARK-41834/conf. Lead-authored-by: Takuya UESHIN <ueshin@databricks.com> Co-authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 47951c9) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?