[SPARK-41834][CONNECT] Implement SparkSession.conf #40150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
force-pushed
the
issues/SPARK-41834/conf
branch
from
5bc498f to
88fb676
Compare
zhengruifeng
approved these changes
Feb 24, 2023
HyukjinKwon
approved these changes
Feb 24, 2023
Contributor
grundprinzip
left a comment
grundprinzip
left a comment
There was a problem hiding this comment.
I'm ok with the implementaiton, please simplify the KeyValue and simplify the Response.
connector/connect/common/src/main/protobuf/spark/connect/base.proto
Outdated
Show resolved
Hide resolved
connector/connect/common/src/main/protobuf/spark/connect/base.proto
Outdated
Show resolved
Hide resolved
amaliujia
reviewed
Feb 24, 2023
grundprinzip
approved these changes
Feb 24, 2023
Member
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 25, 2023
Implements `SparkSession.conf`. Took #39995 over. `SparkSession.conf` is a missing feature. Yes, `SparkSession.conf` will be available. Added/enabled related tests. Closes #40150 from ueshin/issues/SPARK-41834/conf. Lead-authored-by: Takuya UESHIN <ueshin@databricks.com> Co-authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 47951c9) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
Implements `SparkSession.conf`. Took apache#39995 over. `SparkSession.conf` is a missing feature. Yes, `SparkSession.conf` will be available. Added/enabled related tests. Closes apache#40150 from ueshin/issues/SPARK-41834/conf. Lead-authored-by: Takuya UESHIN <ueshin@databricks.com> Co-authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 47951c9) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implements
SparkSession.conf.Took #39995 over.
Why are the changes needed?
SparkSession.confis a missing feature.Does this PR introduce any user-facing change?
Yes,
SparkSession.confwill be available.How was this patch tested?
Added/enabled related tests.