[SPARK-42470][SQL] Remove unused declarations from Hive module #40053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
LuciferYang
changed the title
huaxingao
approved these changes
Feb 18, 2023
Contributor
|
Merged to master. Thanks @LuciferYang |
Member
|
Thank you, @LuciferYang and @huaxingao ! |
Contributor
Author
|
Thanks @huaxingao @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr cleans up unused declarations in the Hive module:
Input parameter
dataTypesofHiveInspectors#wrapmethod: the input parameterdataTypesintroduced by SPARK-9354, but after SPARK-17509, the implementation ofHiveInspectors#wrapno longer needs to explicitly passdataTypesand it becomes a unused, andinputDataTypesinHiveSimpleUDFbecomes a unused after this prUNLIMITED_DECIMAL_PRECISIONandUNLIMITED_DECIMAL_SCALEinHiveShim: these twovalintroduced by SPARK-6909 for unlimited decimals, but SPARK-9069 remove unlimited precision support for DecimalType and SPARK-14877 deletedobject HiveMetastoreTypesand used.catalogStringinstead, these twovalare not used anymore.Why are the changes needed?
Code clean up.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions