Skip to content

[SPARK-42470][SQL] Remove unused declarations from Hive module #40053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 2 commits into from
Closed

[SPARK-42470][SQL] Remove unused declarations from Hive module #40053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92981eb
remove dataTypes from HiveInspectors#wrap
LuciferYang Feb 16, 2023
2296677
remove UNLIMITED_DECIMAL_PRECISION and UNLIMITED_DECIMAL_SCALE from H…
LuciferYang Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,8 +806,7 @@ private[hive] trait HiveInspectors {
def wrap(
row: Seq[Any],
wrappers: Array[(Any) => Any],
cache: Array[AnyRef],
dataTypes: Array[DataType]): Array[AnyRef] = {
cache: Array[AnyRef]): Array[AnyRef] = {
var i = 0
val length = wrappers.length
while (i < length) {
Expand Down
4 changes: 0 additions & 4 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ import org.apache.spark.sql.types.Decimal
import org.apache.spark.util.Utils

private[hive] object HiveShim {
// Precision and scale to pass for unlimited decimals; these are the same as the precision and
// scale Hive 0.13 infers for BigDecimals from sources that don't specify them (e.g. UDFs)
val UNLIMITED_DECIMAL_PRECISION = 38
val UNLIMITED_DECIMAL_SCALE = 18
val HIVE_GENERIC_UDF_MACRO_CLS = "org.apache.hadoop.hive.ql.udf.generic.GenericUDFMacro"

/*
Expand Down
5 changes: 1 addition & 4 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,9 @@ private[hive] case class HiveSimpleUDF(
@transient
private lazy val cached: Array[AnyRef] = new Array[AnyRef](children.length)

@transient
private lazy val inputDataTypes: Array[DataType] = children.map(_.dataType).toArray

// TODO: Finish input output types.
override def eval(input: InternalRow): Any = {
val inputs = wrap(children.map(_.eval(input)), wrappers, cached, inputDataTypes)
val inputs = wrap(children.map(_.eval(input)), wrappers, cached)
val ret = FunctionRegistry.invoke(
method,
function,
Expand Down